This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Double signer implementation (testing purposes) #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
Stefan-Ethernal
approved these changes
Aug 31, 2023
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Stefan-Ethernal
merged commit f83ada8
into
0xPolygon:feat/double-signer-impl
5 of 6 checks passed
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 5, 2023
* finished code with logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * delete some logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * fix unused imports * fix wrong logger call --------- Co-authored-by: Stefan Negovanović <[email protected]>
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 6, 2023
* finished code with logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * delete some logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * fix unused imports * fix wrong logger call --------- Co-authored-by: Stefan Negovanović <[email protected]>
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 7, 2023
* Double signer implementation (testing purposes) (#1864) * finished code with logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * delete some logs * Update consensus/polybft/transport.go Co-authored-by: Stefan Negovanović <[email protected]> * fix unused imports * fix wrong logger call --------- Co-authored-by: Stefan Negovanović <[email protected]> * Use build tags for double signer implementation * Address comment and rename --------- Co-authored-by: Dusan Nosovic <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes code for double signing blocks. This code is only for testing purposes.
Changes include
Checklist
Testing